Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: ui/events/event.cc

Issue 1776673007: [Windows] Produce correct DomKey for NumPad when combined with Shift/NumLock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/events/keycodes/platform_key_map_win.h » ('j') | ui/events/keycodes/platform_key_map_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event.cc
diff --git a/ui/events/event.cc b/ui/events/event.cc
index ca6704b6f8fa5b6e49888074b799c620b7bc90e2..7bb82a9a43f769b7e2010a9f1d3d8d21f5d07307 100644
--- a/ui/events/event.cc
+++ b/ui/events/event.cc
@@ -865,7 +865,8 @@ KeyEvent::KeyEvent(const base::NativeEvent& native_event)
if (is_char_)
key_ = DomKey::FromCharacter(native_event.wParam);
else
- key_ = PlatformKeyMap::DomCodeAndFlagsToDomKeyStatic(code_, flags());
+ key_ = PlatformKeyMap::DomCodeAndFlagsToDomKeyStatic(code_, key_code_,
dtapuska 2016/03/10 20:51:44 This is certainly odd that we require the key_code
Wez 2016/03/16 21:03:06 So sad. ;( Perhaps it would be cleanest to pass i
+ flags());
#endif
}
« no previous file with comments | « no previous file | ui/events/keycodes/platform_key_map_win.h » ('j') | ui/events/keycodes/platform_key_map_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698