[Windows] Produce correct DomKey for NumPad when combined with Shift/NumLock

ui/events/event.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event.h"
 
 #include <utility>
 
 #if defined(USE_X11)
 #include <X11/extensions/XInput2.h>
@@ skipping 847 matching lines @@
     set_flags(flags() | ui::EF_IS_REPEAT);
 
 #if defined(USE_X11)
   NormalizeFlags();
 #endif
 #if defined(OS_WIN)
   // Only Windows has native character events.
   if (is_char_)
     key_ = DomKey::FromCharacter(native_event.wParam);
   else
-    key_ = PlatformKeyMap::DomCodeAndFlagsToDomKeyStatic(code_, flags());
+    key_ = PlatformKeyMap::DomCodeAndFlagsToDomKeyStatic(code_, key_code_,

[dtapuska, 2016/03/10 20:51:44]

This is certainly odd that we require the key_code_ to be passed in but as you
demonstrated the shift state is incorrect (thanks to native Windows events); so
I don't see how else we could do this.

[Wez, 2016/03/16 21:03:06]

So sad. ;(  Perhaps it would be cleanest to pass in the base::NativeEvent, and
let the PlatformKeyMap pull whatever data it needs out of that?  Passing the
partially-complete KeyEvent would also work, but then you're committed to
keeping the key_code_ field around, where in future it might be possible to kill
it & reconstruct it on-the-fly from the other fields & keymap.

+                                                         flags());
 #endif
 }
 
 KeyEvent::KeyEvent(EventType type,
                    KeyboardCode key_code,
                    int flags)
     : Event(type, EventTimeForNow(), flags),
       key_code_(key_code),
       code_(UsLayoutKeyboardCodeToDomCode(key_code)) {
 }
@@ skipping 268 matching lines @@
                    gfx::PointF(x, y),
                    time_stamp,
                    flags | EF_FROM_TOUCH),
       details_(details) {
 }
 
 GestureEvent::~GestureEvent() {
 }
 
 }  // namespace ui