Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: ui/events/keycodes/platform_key_map_win.h

Issue 1776673007: [Windows] Produce correct DomKey for NumPad when combined with Shift/NumLock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/keycodes/platform_key_map_win.h
diff --git a/ui/events/keycodes/platform_key_map_win.h b/ui/events/keycodes/platform_key_map_win.h
index 7517f2a7ee470d2a78bc7b0a6a88f935dbeffe5d..bc50cdb3965c376f13236092b6313b11f63aeec0 100644
--- a/ui/events/keycodes/platform_key_map_win.h
+++ b/ui/events/keycodes/platform_key_map_win.h
@@ -26,15 +26,18 @@ class EVENTS_BASE_EXPORT PlatformKeyMap {
// Returns the DomKey 'meaning' of |code| in the context of specified
// |ui_event_flags| and stored keyboard layout.
+ // |key_code| will only be used for NumPad.
DomKey DomCodeAndFlagsToDomKey(DomCode code,
+ KeyboardCode key_code,
int ui_event_flags) const;
// Returns the DomKey 'meaning' of |code| in the context of specified
// |ui_event_flags| and the keyboard layout of current thread.
// Updates a per-thread key map cache whenever the layout changes.
- static DomKey DomCodeAndFlagsToDomKeyStatic(
- DomCode code,
- int ui_event_flags);
+ // |key_code| will only be used for NumPad.
+ static DomKey DomCodeAndFlagsToDomKeyStatic(DomCode code,
+ KeyboardCode key_code,
+ int ui_event_flags);
chongz 2016/03/10 00:59:10 This interface looks ugly but I don't have a bette
private:
PlatformKeyMap();

Powered by Google App Engine
This is Rietveld 408576698