Increase width of viewportConstrainedNotCompositingReasons

Increase width of viewportConstrainedNotCompositingReasons

The member was no longer big enough to store all the 
enumerators so the setter could fail. The net result was
that if you tried to set the reason to 4, it *always*
looked like this reason changed. I was seeing a full
tree build on every mouse move!

R=abarth@chromium.org
BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168181

[enne (OOO), 2014-02-28 20:28:46]

Please also format your description to <80 (ideally <=72) cols.

https://codereview.chromium.org/177653010/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderLayer.h (right):

https://codereview.chromium.org/177653010/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderLayer.h:441:
ASSERT(viewportConstrainedNotCompositedReason() == reason);
Compile assert?

[Ian Vollick, 2014-02-28 20:42:02]

On 2014/02/28 20:28:46, enne wrote:
> Please also format your description to <80 (ideally <=72) cols.
Done.
> 
>
https://codereview.chromium.org/177653010/diff/20001/Source/core/rendering/Re...
> File Source/core/rendering/RenderLayer.h (right):
> 
>
https://codereview.chromium.org/177653010/diff/20001/Source/core/rendering/Re...
> Source/core/rendering/RenderLayer.h:441:
> ASSERT(viewportConstrainedNotCompositedReason() == reason);
> Compile assert?
Based on offline discussion, switched the storage. It's no longer bit packed.
I'm not sure a compiler assert makes sense any longer. WDYT?

[enne (OOO), 2014-02-28 20:47:07]

https://codereview.chromium.org/177653010/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderLayer.h (right):

https://codereview.chromium.org/177653010/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderLayer.h:437:
ASSERT(viewportConstrainedNotCompositedReason() == reason);
Not sure this makes any sense either anymore.

[Ian Vollick, 2014-02-28 21:55:16]

On 2014/02/28 20:47:07, enne wrote:
>
https://codereview.chromium.org/177653010/diff/40001/Source/core/rendering/Re...
> File Source/core/rendering/RenderLayer.h (right):
> 
>
https://codereview.chromium.org/177653010/diff/40001/Source/core/rendering/Re...
> Source/core/rendering/RenderLayer.h:437:
> ASSERT(viewportConstrainedNotCompositedReason() == reason);
> Not sure this makes any sense either anymore.

Back to bit packing. Added the compile time assert. WDYT?

[enne (OOO), 2014-02-28 22:09:48]

https://codereview.chromium.org/177653010/diff/70001/Source/core/rendering/Re...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/177653010/diff/70001/Source/core/rendering/Re...
Source/core/rendering/RenderLayer.cpp:4014: COMPILE_ASSERT(1 << 3 >=
RenderLayer::NumNotCompositedReasons,
too_many_viewport_constrained_not_compositing_reasons);
The duplicate 3 is here is unfortunate.  Somebody could update one but not the
other.  Can you use sizeof? Or something else?

[enne (OOO), 2014-02-28 23:57:18]

lgtm

[Ian Vollick, 2014-02-28 23:59:08]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:59:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/177653010/90002

[commit-bot: I haz the power, 2014-03-01 01:31:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 01:31:27]

Retried try job too often on blink_android_compile_dbg for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...

[Ian Vollick, 2014-03-01 01:38:20]

The CQ bit was checked by vollick@chromium.org

[commit-bot: I haz the power, 2014-03-01 01:38:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/177653010/90002

[commit-bot: I haz the power, 2014-03-01 02:03:37]

Change committed as 168181