Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Unified Diff: Source/core/rendering/RenderLayer.h

Issue 177653010: Increase width of viewportConstrainedNotCompositingReasons (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use an enum because #define is gross. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayer.h
diff --git a/Source/core/rendering/RenderLayer.h b/Source/core/rendering/RenderLayer.h
index b0e5ffbd6c6cbd34717db55785cace48550097dc..de37e9a4b4dc5cfa6c79e9046ec7aed67962b07f 100644
--- a/Source/core/rendering/RenderLayer.h
+++ b/Source/core/rendering/RenderLayer.h
@@ -424,11 +424,17 @@ public:
bool isInTopLayerSubtree() const;
enum ViewportConstrainedNotCompositedReason {
- NoNotCompositedReason,
+ NoNotCompositedReason = 0,
NotCompositedForBoundsOutOfView,
NotCompositedForNonViewContainer,
NotCompositedForNoVisibleContent,
NotCompositedForUnscrollableAncestors,
+ NumNotCompositedReasons,
+
+ // This is the number of bits used to store the viewport constrained not composited
+ // reasons. We define this constant since sizeof won't return the number of bits, and we
+ // shouldn't duplicate the constant.
+ ViewportConstrainedNotCompositedReasonBits = 3
};
void setViewportConstrainedNotCompositedReason(ViewportConstrainedNotCompositedReason reason) { m_compositingProperties.viewportConstrainedNotCompositedReason = reason; }
@@ -731,7 +737,7 @@ protected:
bool lostGroupedMapping : 1;
// The reason, if any exists, that a fixed-position layer is chosen not to be composited.
- unsigned viewportConstrainedNotCompositedReason : 2;
+ unsigned viewportConstrainedNotCompositedReason : ViewportConstrainedNotCompositedReasonBits;
// Once computed, indicates all that a layer needs to become composited using the CompositingReasons enum bitfield.
CompositingReasons compositingReasons;
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698