Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: Source/core/rendering/RenderLayer.h

Issue 177653010: Increase width of viewportConstrainedNotCompositingReasons (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use an enum because #define is gross. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 void setHasFilterInfo(bool hasFilterInfo) { m_hasFilterInfo = hasFilterInfo; } 417 void setHasFilterInfo(bool hasFilterInfo) { m_hasFilterInfo = hasFilterInfo; }
418 418
419 void updateFilters(const RenderStyle* oldStyle, const RenderStyle* newStyle) ; 419 void updateFilters(const RenderStyle* oldStyle, const RenderStyle* newStyle) ;
420 420
421 Node* enclosingElement() const; 421 Node* enclosingElement() const;
422 422
423 bool isInTopLayer() const; 423 bool isInTopLayer() const;
424 bool isInTopLayerSubtree() const; 424 bool isInTopLayerSubtree() const;
425 425
426 enum ViewportConstrainedNotCompositedReason { 426 enum ViewportConstrainedNotCompositedReason {
427 NoNotCompositedReason, 427 NoNotCompositedReason = 0,
428 NotCompositedForBoundsOutOfView, 428 NotCompositedForBoundsOutOfView,
429 NotCompositedForNonViewContainer, 429 NotCompositedForNonViewContainer,
430 NotCompositedForNoVisibleContent, 430 NotCompositedForNoVisibleContent,
431 NotCompositedForUnscrollableAncestors, 431 NotCompositedForUnscrollableAncestors,
432 NumNotCompositedReasons,
433
434 // This is the number of bits used to store the viewport constrained not composited
435 // reasons. We define this constant since sizeof won't return the number of bits, and we
436 // shouldn't duplicate the constant.
437 ViewportConstrainedNotCompositedReasonBits = 3
432 }; 438 };
433 439
434 void setViewportConstrainedNotCompositedReason(ViewportConstrainedNotComposi tedReason reason) { m_compositingProperties.viewportConstrainedNotCompositedReas on = reason; } 440 void setViewportConstrainedNotCompositedReason(ViewportConstrainedNotComposi tedReason reason) { m_compositingProperties.viewportConstrainedNotCompositedReas on = reason; }
435 ViewportConstrainedNotCompositedReason viewportConstrainedNotCompositedReaso n() const { return static_cast<ViewportConstrainedNotCompositedReason>(m_composi tingProperties.viewportConstrainedNotCompositedReason); } 441 ViewportConstrainedNotCompositedReason viewportConstrainedNotCompositedReaso n() const { return static_cast<ViewportConstrainedNotCompositedReason>(m_composi tingProperties.viewportConstrainedNotCompositedReason); }
436 442
437 bool isOutOfFlowRenderFlowThread() const { return renderer()->isOutOfFlowRen derFlowThread(); } 443 bool isOutOfFlowRenderFlowThread() const { return renderer()->isOutOfFlowRen derFlowThread(); }
438 444
439 bool scrollsWithRespectTo(const RenderLayer*) const; 445 bool scrollsWithRespectTo(const RenderLayer*) const;
440 446
441 void addLayerHitTestRects(LayerHitTestRects&) const; 447 void addLayerHitTestRects(LayerHitTestRects&) const;
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 bool hasNonCompositedChild : 1; 730 bool hasNonCompositedChild : 1;
725 731
726 // Should be for stacking contexts having unisolated blending descendant s. 732 // Should be for stacking contexts having unisolated blending descendant s.
727 bool shouldIsolateCompositedDescendants : 1; 733 bool shouldIsolateCompositedDescendants : 1;
728 734
729 // True if this render layer just lost its grouped mapping due to the Co mpositedLayerMapping being destroyed, 735 // True if this render layer just lost its grouped mapping due to the Co mpositedLayerMapping being destroyed,
730 // and we don't yet know to what graphics layer this RenderLayer will be assigned. 736 // and we don't yet know to what graphics layer this RenderLayer will be assigned.
731 bool lostGroupedMapping : 1; 737 bool lostGroupedMapping : 1;
732 738
733 // The reason, if any exists, that a fixed-position layer is chosen not to be composited. 739 // The reason, if any exists, that a fixed-position layer is chosen not to be composited.
734 unsigned viewportConstrainedNotCompositedReason : 2; 740 unsigned viewportConstrainedNotCompositedReason : ViewportConstrainedNot CompositedReasonBits;
735 741
736 // Once computed, indicates all that a layer needs to become composited using the CompositingReasons enum bitfield. 742 // Once computed, indicates all that a layer needs to become composited using the CompositingReasons enum bitfield.
737 CompositingReasons compositingReasons; 743 CompositingReasons compositingReasons;
738 744
739 // Used for invalidating this layer's contents on the squashing Graphics Layer. 745 // Used for invalidating this layer's contents on the squashing Graphics Layer.
740 IntSize offsetFromSquashingLayerOrigin; 746 IntSize offsetFromSquashingLayerOrigin;
741 }; 747 };
742 748
743 CompositingProperties m_compositingProperties; 749 CompositingProperties m_compositingProperties;
744 750
(...skipping 14 matching lines...) Expand all
759 765
760 } // namespace WebCore 766 } // namespace WebCore
761 767
762 #ifndef NDEBUG 768 #ifndef NDEBUG
763 // Outside the WebCore namespace for ease of invocation from gdb. 769 // Outside the WebCore namespace for ease of invocation from gdb.
764 void showLayerTree(const WebCore::RenderLayer*); 770 void showLayerTree(const WebCore::RenderLayer*);
765 void showLayerTree(const WebCore::RenderObject*); 771 void showLayerTree(const WebCore::RenderObject*);
766 #endif 772 #endif
767 773
768 #endif // RenderLayer_h 774 #endif // RenderLayer_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698