Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issue 1776373003: Consolidate SpdyFramer::WriteHeaderBlock() and SerializeHeaderBlockWithoutCompression(). (Closed)

Created:
4 years, 9 months ago by Bence
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate SpdyFramer::WriteHeaderBlock() and SerializeHeaderBlockWithoutCompression(). SpdyFramer::WriteHeaderBlock() and SpdyFramer::SerializeHeaderBlockWithoutCompression() are identical, except one of them is static. This CL slays this redundancy. * Remove WriteHeaderBlock(). * Change SerializeHeaderBlockWithoutCompression() to public so that it can be called from net/quic/spdy_utils.cc. * Instantiate a SpdyFramer in net/quic/spdy_utils.cc (WriteHeaderBlock used to be static) and call SerializeUncompressedHeaders on it. This CL lands server change 116771332 by bnc. BUG=521600, 488484 Committed: https://crrev.com/33557b831bb6c4feb3b5cc9bc176fc0148f37e8c Cr-Commit-Position: refs/heads/master@{#380445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M net/quic/spdy_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +3 lines, -8 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 9 months ago (2016-03-10 01:17:41 UTC) #2
Ryan Hamilton
lgtm
4 years, 9 months ago (2016-03-10 19:03:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776373003/1
4 years, 9 months ago (2016-03-10 19:12:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 19:27:01 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:27:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33557b831bb6c4feb3b5cc9bc176fc0148f37e8c
Cr-Commit-Position: refs/heads/master@{#380445}

Powered by Google App Engine
This is Rietveld 408576698