Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: net/spdy/spdy_framer.h

Issue 1776373003: Consolidate SpdyFramer::WriteHeaderBlock() and SerializeHeaderBlockWithoutCompression(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/spdy_utils.cc ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer.h
diff --git a/net/spdy/spdy_framer.h b/net/spdy/spdy_framer.h
index 6fce7837ce8d7aa932a5ac20a7697bf1f06c5749..30e7899bd1c3ca516296d843b7a34c3c48825458 100644
--- a/net/spdy/spdy_framer.h
+++ b/net/spdy/spdy_framer.h
@@ -352,10 +352,9 @@ class NET_EXPORT_PRIVATE SpdyFramer {
// purposes.)
static const size_t kHeaderDataChunkMaxSize;
- // Serializes a SpdyHeaderBlock.
- static void WriteHeaderBlock(SpdyFrameBuilder* frame,
- const SpdyMajorVersion spdy_version,
- const SpdyHeaderBlock* headers);
+ void SerializeHeaderBlockWithoutCompression(
+ SpdyFrameBuilder* builder,
+ const SpdyHeaderBlock& header_block) const;
// Retrieve serialized length of SpdyHeaderBlock.
// TODO(hkhalil): Remove, or move to quic code.
@@ -691,10 +690,6 @@ class NET_EXPORT_PRIVATE SpdyFramer {
void WriteHeaderBlockToZ(const SpdyHeaderBlock* headers,
z_stream* out) const;
- void SerializeHeaderBlockWithoutCompression(
- SpdyFrameBuilder* builder,
- const SpdyHeaderBlock& header_block) const;
-
// Compresses automatically according to enable_compression_.
void SerializeHeaderBlock(SpdyFrameBuilder* builder,
const SpdyFrameWithHeaderBlockIR& frame);
« no previous file with comments | « net/quic/spdy_utils.cc ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698