net/quic/spdy_utils.cc - Issue 1776373003: Consolidate SpdyFramer::WriteHeaderBlock() and SerializeHeaderBlockWithoutCompression().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/spdy_utils.cc

Issue 1776373003: Consolidate SpdyFramer::WriteHeaderBlock() and SerializeHeaderBlockWithoutCompression(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/spdy_utils.cc

diff --git a/net/quic/spdy_utils.cc b/net/quic/spdy_utils.cc

index b5aeb1a07acb662bb1b2af3ab58b87562aaef22a..623637dd27f1c6133fc4d3f52053a830058740e6 100644

--- a/net/quic/spdy_utils.cc

+++ b/net/quic/spdy_utils.cc

@@ -26,7 +26,8 @@ string SpdyUtils::SerializeUncompressedHeaders(const SpdyHeaderBlock& headers) {

size_t length = SpdyFramer::GetSerializedLength(spdy_version, &headers);

SpdyFrameBuilder builder(length, spdy_version);

- SpdyFramer::WriteHeaderBlock(&builder, spdy_version, &headers);

+ SpdyFramer framer(spdy_version);

+ framer.SerializeHeaderBlockWithoutCompression(&builder, headers);

scoped_ptr<SpdyFrame> block(builder.take());

return string(block->data(), length);

}

« no previous file with comments | « no previous file | net/spdy/spdy_framer.h » ('j') | no next file with comments »