Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1775933004: [merge-m49] CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen. (Closed)

Created:
4 years, 9 months ago by tapted
Modified:
4 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[merge-m49] CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen. This regressed in r362878 which didn't handle a case where animations occur in immersive fullscreen. To fix, disable layer-painting of tab spinners while in fullscreen. In most cases the tab is hidden or animating; layers shouldn't be used. When the tab strip is fully revealed we could use layers, but the benefit isn't worth the extra logic. TBR=tapted@chromium.org BUG=591535 TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the tab strip while the page is still loading, then move the mouse down to dismiss the tab strip. Ensure a frozen throbber doesn't stick around, floating over the page. Review URL: https://codereview.chromium.org/1758183002 Cr-Commit-Position: refs/heads/master@{#379140} (cherry picked from commit fde5de1bc63b656dabaafef3e5b59badcc613a22) Committed: https://chromium.googlesource.com/chromium/src/+/449279b9ecb1f2b2ff1d20f4a296fcc880badc7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tapted
4 years, 9 months ago (2016-03-09 08:24:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
449279b9ecb1f2b2ff1d20f4a296fcc880badc7c.

Powered by Google App Engine
This is Rietveld 408576698