CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around, floating over the page.

Committed: https://crrev.com/fde5de1bc63b656dabaafef3e5b59badcc613a22
Cr-Commit-Position: refs/heads/master@{#379140}

[tapted, 2016-03-03 03:56:07]

Description was changed from

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

BUG=591535
==========

to

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
==========

[tapted, 2016-03-03 03:56:07]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-03-03 04:03:06]

Description was changed from

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
==========

to

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around on the page.
==========

[tapted, 2016-03-03 04:03:41]

Description was changed from

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around on the page.
==========

to

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around, floating over the page.
==========

[tapted, 2016-03-03 05:01:57]

Hi sky please take a look. And sorry for the regression! I'll try to merge this
into as many branches as the release maintainers will let me.

[sky, 2016-03-03 20:31:01]

https://codereview.chromium.org/1758183002/diff/1/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab_strip.cc (right):

https://codereview.chromium.org/1758183002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.cc:1387: !GetWidget()->IsFullscreen();
Are you sure you don't need a null check for GetWidget() here? I could easily
see this being triggered while there is no widget.

[tapted, 2016-03-03 22:44:07]

https://codereview.chromium.org/1758183002/diff/1/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab_strip.cc (right):

https://codereview.chromium.org/1758183002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab_strip.cc:1387: !GetWidget()->IsFullscreen();
On 2016/03/03 20:31:01, sky wrote:
> Are you sure you don't need a null check for GetWidget() here? I could easily
> see this being triggered while there is no widget.

Added a null check - leaving it off certainly wasn't intentional. Thanks for
catching this! (And you're right - I couldn't find any protections e.g., in the
timer callback at BrowserView::LoadingAnimationCallback() where this is
triggered.)

[sky, 2016-03-03 23:43:22]

LGTM

[tapted, 2016-03-03 23:44:37]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-03-03 23:45:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1758183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1758183002/20001

[commit-bot: I haz the power, 2016-03-03 23:51:02]

Description was changed from

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around, floating over the page.
==========

to

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around, floating over the page.
==========

[commit-bot: I haz the power, 2016-03-03 23:51:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 23:52:26]

Description was changed from

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around, floating over the page.
==========

to

==========
CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen.

This regressed in r362878 which didn't handle a case where animations
occur in immersive fullscreen.

To fix, disable layer-painting of tab spinners while in fullscreen.
In most cases the tab is hidden or animating; layers shouldn't
be used. When the tab strip is fully revealed we could use layers,
but the benefit isn't worth the extra logic.

BUG=591535
TEST=On CrOS, enter immersive fullscreen, reload a page, reveal the
tab strip while the page is still loading, then move the mouse down
to dismiss the tab strip. Ensure a frozen throbber doesn't stick
around, floating over the page.

Committed: https://crrev.com/fde5de1bc63b656dabaafef3e5b59badcc613a22
Cr-Commit-Position: refs/heads/master@{#379140}
==========

[commit-bot: I haz the power, 2016-03-03 23:52:27]

Patchset 2 (id:??) landed as
https://crrev.com/fde5de1bc63b656dabaafef3e5b59badcc613a22
Cr-Commit-Position: refs/heads/master@{#379140}