Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3216)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 1775933004: [merge-m49] CrOS: Don't paint tab-loading spinners in layers while in immersive fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2623
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 56a420c2ba82aa5671ad06a8b57fcbbcb1ebb802..a3e10441a9cebb1fcfa71081df5a6ec4cd64e392 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -1372,9 +1372,13 @@ bool TabStrip::ShouldPaintTab(const Tab* tab, gfx::Rect* clip) {
bool TabStrip::CanPaintThrobberToLayer() const {
// Disable layer-painting of throbbers if dragging, if any tab animation is in
- // progress, or if stacked tabs are enabled.
+ // progress, or if stacked tabs are enabled. Also disable in fullscreen: when
+ // "immersive" the tab strip could be sliding in or out while transitioning to
+ // or away from |immersive_style_| and, for other modes, there's no tab strip.
const bool dragging = drag_controller_ && drag_controller_->started_drag();
- return !touch_layout_ && !dragging && !IsAnimating();
+ const views::Widget* widget = GetWidget();
+ return widget && !touch_layout_ && !dragging && !IsAnimating() &&
+ !widget->IsFullscreen();
}
bool TabStrip::IsImmersiveStyle() const {
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698