Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1775903002: [wasm] Int64Lowering of I64XConvertFXX instructions. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
titzer, Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Int64Lowering of I64XConvertFXX instructions. On 32-bit systems I64XConvertFXX instructions are compiled to calls to C functions. The TF node for the function call is already generated in the wasm compiler, the lowering of the I64 parameter is done in the Int64Lowering. We use the return value of the C function to determine whether the conversion should trap or not. R=titzer@chromium.org Committed: https://crrev.com/d57d14b9784b98dd5501116608f6b8ea6b59900e Cr-Commit-Position: refs/heads/master@{#34738}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -100 lines) Patch
M src/assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 1 3 chunks +109 lines, -39 lines 0 comments Download
M src/snapshot/serializer-common.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-external-refs.h View 1 chunk +47 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-calls-to-external-references.cc View 1 chunk +93 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ahaas
4 years, 9 months ago (2016-03-08 11:44:05 UTC) #1
Yang
serializer lgtm.
4 years, 9 months ago (2016-03-08 11:55:59 UTC) #3
titzer
On 2016/03/08 11:55:59, Yang wrote: > serializer lgtm. lgtm
4 years, 9 months ago (2016-03-14 10:11:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775903002/20001
4 years, 9 months ago (2016-03-14 10:12:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 10:13:57 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 10:14:30 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d57d14b9784b98dd5501116608f6b8ea6b59900e
Cr-Commit-Position: refs/heads/master@{#34738}

Powered by Google App Engine
This is Rietveld 408576698