Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1769163002: Add a instance groups to Connect(), and introduce an Identity struct. (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a instance groups to Connect(), and introduce an Identity struct. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/9a8e15f6e8b9de90a8dff395a68ea6212226786f Cr-Commit-Position: refs/heads/master@{#379757}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -555 lines) Patch
M ash/mus/sysui_application.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M ash/mus/sysui_application.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_app.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -3 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/font_service_app.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -3 lines 0 comments Download
M components/leveldb/leveldb_app.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M components/mus/mus_app.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/mus_app.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +4 lines, -5 lines 0 comments Download
M components/profile_service/profile_app.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M components/profile_service/profile_app.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -4 lines 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -9 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/test_mojo_app.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -2 lines 0 comments Download
M content/test/data/web_ui_mojo_shell_test.js View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M mash/init/init.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mash/init/init.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -9 lines 0 comments Download
M mash/login/login.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mash/login/login.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M mash/screenlock/screenlock.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M mash/screenlock/screenlock.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -3 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M mash/shell/shell_application_delegate.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -7 lines 0 comments Download
M mash/wm/window_manager_application.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/package_manager/package_manager.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/shell/background/background_shell.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/connect_params.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/connect_util.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/identity.h View 1 2 3 4 5 6 1 chunk +0 lines, -83 lines 0 comments Download
M mojo/shell/identity.cc View 1 2 3 4 5 6 1 chunk +0 lines, -78 lines 0 comments Download
M mojo/shell/native_runner.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/native_runner_delegate.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/connection.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/public/cpp/connector.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -5 lines 0 comments Download
A mojo/shell/public/cpp/identity.h View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 1 2 3 3 chunks +8 lines, -12 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 1 2 3 4 5 6 7 4 chunks +5 lines, -7 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -12 lines 0 comments Download
M mojo/shell/public/cpp/lib/connector_impl.cc View 1 2 3 4 5 6 7 3 chunks +11 lines, -12 lines 0 comments Download
A mojo/shell/public/cpp/lib/identity.cc View 1 2 3 4 5 6 7 8 9 1 chunk +60 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/interface_registry.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/shell_client.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -8 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_test.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/shell_client.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/shell_test.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/public/interfaces/connector.mojom View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +34 lines, -20 lines 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/shell/public/interfaces/shell_client.mojom View 1 3 chunks +14 lines, -24 lines 0 comments Download
M mojo/shell/runner/host/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/shell.h View 1 2 3 4 5 6 4 chunks +22 lines, -2 lines 0 comments Download
M mojo/shell/shell.cc View 1 2 3 4 5 6 17 chunks +97 lines, -56 lines 0 comments Download
M mojo/shell/standalone/context.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/shell/tests/connect/connect_test.mojom View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app.cc View 1 2 3 4 5 6 7 8 4 chunks +11 lines, -10 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_package.cc View 1 2 3 4 5 6 7 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/shell/tests/connect/connect_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +52 lines, -4 lines 0 comments Download
M mojo/shell/tests/lifecycle/lifecycle_unittest.cc View 1 2 3 4 chunks +16 lines, -14 lines 0 comments Download
M mojo/shell/tests/loader_unittest.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/tests/shell/driver.cc View 1 2 3 4 5 6 7 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/shell/tests/shell/shell_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/shell/target.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
Ben Goodger (Google)
moar Initialize signature changes. interesting stuff in src/mojo/shell
4 years, 9 months ago (2016-03-08 00:01:10 UTC) #2
sky
LGTM with a better description for Identity.instance
4 years, 9 months ago (2016-03-08 00:08:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769163002/210001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769163002/210001
4 years, 9 months ago (2016-03-08 00:31:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/154016) linux_site_isolation on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-08 00:41:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769163002/230001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769163002/230001
4 years, 9 months ago (2016-03-08 03:33:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/126761) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-08 03:41:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769163002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769163002/250001
4 years, 9 months ago (2016-03-08 03:46:50 UTC) #17
commit-bot: I haz the power
Committed patchset #14 (id:250001)
4 years, 9 months ago (2016-03-08 05:17:57 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 05:19:25 UTC) #20
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/9a8e15f6e8b9de90a8dff395a68ea6212226786f
Cr-Commit-Position: refs/heads/master@{#379757}

Powered by Google App Engine
This is Rietveld 408576698