Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Issue 1775363002: Avoiding losing too much precision when hit-testing SVG <text> (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoiding losing too much precision when hit-testing SVG <text> Using flooredIntPoint() will lose all fractional precision - which is too much considering that the location is actually at least a LayoutPoint. Use the HitTestLocation(const FloatPoint&) constructor instead - which does flooredLayoutPoint() behind scenes but also retains the FloatPoint. Do the same for LayoutSVGForeignObject, since it has similar requirements. BUG=466617 Committed: https://crrev.com/a8807dbd794e4c18199c569b453ffd1943257642 Cr-Commit-Position: refs/heads/master@{#380144}

Patch Set 1 #

Patch Set 2 : Add -expected.txt #

Patch Set 3 : Use HitTestLocation(const FloatPoint&) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
fs
4 years, 9 months ago (2016-03-09 14:10:09 UTC) #3
Stephen Chennney
lgtm
4 years, 9 months ago (2016-03-09 15:17:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775363002/40001
4 years, 9 months ago (2016-03-09 16:20:11 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 16:24:43 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 16:26:00 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a8807dbd794e4c18199c569b453ffd1943257642
Cr-Commit-Position: refs/heads/master@{#380144}

Powered by Google App Engine
This is Rietveld 408576698