third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp - Issue 1775363002: Avoiding losing too much precision when hit-testing SVG <text>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Issue 1775363002: Avoiding losing too much precision when hit-testing SVG <text> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use HitTestLocation(const FloatPoint&) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

index 1a0da090adb420da1ecbea8e8f7236019ac8f197..e1faa50212cfaed22db1bca5633be343ce6af9c8 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

@@ -420,7 +420,7 @@ bool LayoutSVGText::nodeAtFloatPoint(HitTestResult& result, const FloatPoint& po

if (hitRules.canHitBoundingBox && !objectBoundingBox().contains(localPoint))

return false;

- HitTestLocation hitTestLocation(LayoutPoint(flooredIntPoint(localPoint)));

+ HitTestLocation hitTestLocation(localPoint);

return LayoutBlock::nodeAtPoint(result, hitTestLocation, LayoutPoint(), hitTestAction);

}

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp ('k') | no next file » | no next file with comments »