third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp - Issue 1775363002: Avoiding losing too much precision when hit-testing SVG <text>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

Issue 1775363002: Avoiding losing too much precision when hit-testing SVG <text> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use HitTestLocation(const FloatPoint&) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/hittest/text-small-font-size-and-viewbox-expected.txt ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

index 5770859606b4089fd05c57f4d555d112b7ad959a..7c9a97c2580f04fd9cff1f7656748b6341028201 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

@@ -137,7 +137,7 @@ bool LayoutSVGForeignObject::nodeAtFloatPoint(HitTestResult& result, const Float

return false;

// FOs establish a stacking context, so we need to hit-test all layers.

- HitTestLocation hitTestLocation(roundedLayoutPoint(localPoint));

+ HitTestLocation hitTestLocation(localPoint);

return LayoutBlock::nodeAtPoint(result, hitTestLocation, LayoutPoint(), HitTestForeground)

|| LayoutBlock::nodeAtPoint(result, hitTestLocation, LayoutPoint(), HitTestFloat)

|| LayoutBlock::nodeAtPoint(result, hitTestLocation, LayoutPoint(), HitTestChildBlockBackgrounds);