Capability Classes

Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}

Committed: https://crrev.com/071019d49fecf779429d88557f9368cf1e2d1f2f
Cr-Commit-Position: refs/heads/master@{#380644}

[Ben Goodger (Google), 2016-03-10 04:38:42]

Description was changed from

==========
Capability Classes

BUG=
==========

to

==========
Capability Classes

BUG=
==========

[Ben Goodger (Google), 2016-03-10 06:29:31]

Description was changed from

==========
Capability Classes

BUG=
==========

to

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=
==========

[Ben Goodger (Google), 2016-03-10 06:29:31]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-03-10 16:57:32]

LGTM

[Ben Goodger (Google), 2016-03-10 18:38:00]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-03-10 18:38:01]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1781913003/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-03-10 18:38:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/120001

[commit-bot: I haz the power, 2016-03-10 20:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 20:25:01]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-03-10 21:18:04]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:18:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/120001

[commit-bot: I haz the power, 2016-03-10 22:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:37:31]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-03-10 23:00:15]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:01:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/120001

[Ben Goodger (Google), 2016-03-10 23:26:42]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-03-10 23:26:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1781913003/#ps140001
(title: ".")

[commit-bot: I haz the power, 2016-03-10 23:27:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/140001

[commit-bot: I haz the power, 2016-03-11 00:08:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:08:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-03-11 00:34:35]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:35:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/140001

[yzshen1, 2016-03-11 01:03:38]

The CQ bit was unchecked by yzshen@chromium.org

[yzshen1, 2016-03-11 01:07:03]

On 2016/03/11 00:35:14, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1781913003/140001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1781913003/140001

Hi, Ben.

My CL of changing '::' to '.' was reverted again. It passed CQ but eventually
broke some slow-running android bot.

I don't want to block your change any longer. Please land your first.

I will figure out the issue and maybe land the CL during weekend to avoid
conflicts.

Sorry for the inconvenience!

[Ben Goodger (Google), 2016-03-11 01:38:09]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-03-11 01:38:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/140001

[commit-bot: I haz the power, 2016-03-11 02:09:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 02:09:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-03-11 05:22:26]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-03-11 05:23:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/140001

[commit-bot: I haz the power, 2016-03-11 06:15:09]

Description was changed from

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=
==========

to

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-03-11 06:15:10]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-11 06:16:33]

Description was changed from

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=
==========

to

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}
==========

[commit-bot: I haz the power, 2016-03-11 06:16:34]

Patchset 8 (id:??) landed as
https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}

[vasilii, 2016-03-11 10:44:14]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1783303002/ by vasilii@chromium.org.

The reason for reverting is: Broke mojo_shell_unittests  on Linux Tests
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/388...)

[ RUN      ] ConnectTest.CapabilityClasses
[0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter
prevented binding to interface: mojo::shell::test::mojom::BlockedInterface
connection_name:mojo:connect_test_app remote_name:mojo:connect_unittests
[0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter
prevented binding to interface: mojo::shell::test::mojom::ConnectTestService
connection_name:mojo:connect_test_class_app remote_name:mojo:connect_test_app
[0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter
prevented binding to interface: mojo::shell::test::mojom::ClassInterface
connection_name:mojo:connect_test_class_app remote_name:mojo:connect_test_app
[ERROR:child_process_base.cc(212)] Connection error to the shell.
[ERROR:child_process_base.cc(212)] Connection error to the shell.
[37/37] ConnectTest.CapabilityClasses (TIMED OUT).

[Ben Goodger (Google), 2016-03-11 14:57:38]

Description was changed from

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}
==========

to

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}
==========

[Ben Goodger (Google), 2016-03-11 15:04:33]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-03-11 15:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1781913003/#ps160001
(title: ".")

[commit-bot: I haz the power, 2016-03-11 15:04:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781913003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781913003/160001

[commit-bot: I haz the power, 2016-03-11 16:08:00]

Description was changed from

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}
==========

to

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}
==========

[commit-bot: I haz the power, 2016-03-11 16:08:01]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-11 16:09:27]

Description was changed from

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}
==========

to

==========
Implement capability classes:

- pass the union of the interfaces in the "interfaces" list of the capability
request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting

R=sky@chromium.org
BUG=

Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}

Committed: https://crrev.com/071019d49fecf779429d88557f9368cf1e2d1f2f
Cr-Commit-Position: refs/heads/master@{#380644}
==========

[commit-bot: I haz the power, 2016-03-11 16:09:29]

Patchset 9 (id:??) landed as
https://crrev.com/071019d49fecf779429d88557f9368cf1e2d1f2f
Cr-Commit-Position: refs/heads/master@{#380644}