third_party/WebKit/Source/web/WebPluginContainerImpl.h - Issue 1774653002: Decouple scheduling animation of webview plugins from layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.h

Issue 1774653002: Decouple scheduling animation of webview plugins from layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp ('K') | « third_party/WebKit/Source/core/plugins/PluginView.h ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | third_party/WebKit/public/web/WebPluginContainer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.h

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.h b/third_party/WebKit/Source/web/WebPluginContainerImpl.h

index 72f25f07044e038d9b20a5b0c9f1b55e313d0879..38867769228028a6c3ab8ef931bb21b8607efd01 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.h

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.h

@@ -78,7 +78,7 @@ public:

bool supportsInputMethod() const override;

bool canProcessDrag() const override;

bool wantsWheelEvents() override;

- void layoutIfNeeded() override;

+ void updateAllLifecyclePhases() override;

void invalidatePaintIfNeeded() override { issuePaintInvalidations(); }

// Widget methods

@@ -102,7 +102,7 @@ public:

void invalidate() override;

void invalidateRect(const WebRect&) override;

void scrollRect(const WebRect&) override;

- void setNeedsLayout() override;

+ void scheduleAnimation() override;

void reportGeometry() override;

void allowScriptObjects() override;

void clearScriptObjects() override;