[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.

[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
Committed: https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38
Cr-Commit-Position: refs/heads/master@{#381112}

[dgozman, 2016-03-08 22:44:34]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-03-08 22:44:34]

Take a look please.

[pfeldman, 2016-03-10 02:43:50]

lgtm

[dgozman, 2016-03-10 02:45:43]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-10 02:46:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/1

[commit-bot: I haz the power, 2016-03-10 02:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 02:49:47]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-03-10 17:29:19]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-10 17:29:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1774323002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-10 17:29:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/20001

[commit-bot: I haz the power, 2016-03-10 19:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 19:11:32]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-10 22:04:47]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-10 22:04:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1774323002/#ps40001
(title: "win compile")

[commit-bot: I haz the power, 2016-03-10 22:05:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/40001

[commit-bot: I haz the power, 2016-03-10 22:45:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:46:00]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-10 22:47:12]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-10 22:48:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/40001

[commit-bot: I haz the power, 2016-03-10 23:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:20:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-10 23:22:40]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:23:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/40001

[commit-bot: I haz the power, 2016-03-10 23:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 23:45:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-03-11 02:30:43]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-11 02:31:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/40001

[commit-bot: I haz the power, 2016-03-11 03:09:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 03:09:05]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-11 06:20:11]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-11 06:20:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/40001

[commit-bot: I haz the power, 2016-03-11 07:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 07:51:24]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-11 17:05:33]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-03-11 17:05:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/40001

[commit-bot: I haz the power, 2016-03-11 17:51:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-11 17:53:13]

Description was changed from

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

to

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878

Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
Cr-Commit-Position: refs/heads/master@{#380666}
==========

[commit-bot: I haz the power, 2016-03-11 17:53:14]

Patchset 3 (id:??) landed as
https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
Cr-Commit-Position: refs/heads/master@{#380666}

[alexmos, 2016-03-11 18:12:16]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1777323004/ by alexmos@chromium.org.

The reason for reverting is: Seems to have broken compile on WebKit Linux
non-Oilpan Builder:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...

Output snippet:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:31:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h:29:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1:
In file included from gen/blink/core/InstrumentingAgentsInl.h:7:
In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:35:
In file included from
../../third_party/WebKit/Source/platform/heap/HeapAllocator.h:9:
../../third_party/WebKit/Source/platform/heap/TraceTraits.h:173:5: error:
static_assert failed "T should be traced"
    static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T
should be traced");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/heap/Visitor.h:193:24: note: in
instantiation of member function
'blink::TraceTrait<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >::trace' requested here
        TraceTrait<T>::trace(Derived::fromHelper(this), &const_cast<T&>(t));
                       ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:67:14: note:
in instantiation of function template specialization
'blink::VisitorHelper<blink::Visitor>::trace<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >' requested here
    visitor->trace(m_workersWithEnabledConsole);
             ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:63:1: note:
in instantiation of function template specialization
'blink::PageConsoleAgent::traceImpl<blink::Visitor *>' requested here
DEFINE_TRACE(PageConsoleAgent)
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:77:39: note: expanded
from macro 'DEFINE_TRACE'
    void T::trace(Visitor* visitor) { traceImpl(visitor); }                    \
                                      ^

.

[dgozman, 2016-03-11 19:10:28]

Description was changed from

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878

Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
Cr-Commit-Position: refs/heads/master@{#380666}
==========

to

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

[dgozman, 2016-03-11 20:41:43]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-11 20:41:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1774323002/#ps60001
(title: "non-oilpan compile")

[commit-bot: I haz the power, 2016-03-11 20:42:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/60001

[commit-bot: I haz the power, 2016-03-11 22:06:43]

Description was changed from

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

to

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

[commit-bot: I haz the power, 2016-03-11 22:06:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-11 22:09:09]

Description was changed from

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

to

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878

Committed: https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f
Cr-Commit-Position: refs/heads/master@{#380745}
==========

[commit-bot: I haz the power, 2016-03-11 22:09:10]

Patchset 4 (id:??) landed as
https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f
Cr-Commit-Position: refs/heads/master@{#380745}

[dgozman, 2016-03-12 00:54:37]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1777323005/ by dgozman@chromium.org.

The reason for reverting is: Introduced leaks. See
https://bugs.chromium.org/p/chromium/issues/detail?id=594304.

[dgozman, 2016-03-14 20:37:56]

Description was changed from

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878

Committed: https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f
Cr-Commit-Position: refs/heads/master@{#380745}
==========

to

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

[dgozman, 2016-03-14 20:49:50]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-14 20:49:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1774323002/#ps80001
(title: "fixed leaks")

[commit-bot: I haz the power, 2016-03-14 20:50:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774323002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774323002/80001

[commit-bot: I haz the power, 2016-03-14 23:36:34]

Description was changed from

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

to

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

[commit-bot: I haz the power, 2016-03-14 23:36:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-14 23:38:57]

Description was changed from

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878
==========

to

==========
[DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.

For multiclient, we will move the global collection of WorkerInspectorProxy
objects
to a static collection in WorkerInspectorProxy class.

BUG=590878

Committed: https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38
Cr-Commit-Position: refs/heads/master@{#381112}
==========

[commit-bot: I haz the power, 2016-03-14 23:39:00]

Patchset 5 (id:??) landed as
https://crrev.com/d9fd87883c0d8d5b69e07d61a92e149b647b4e38
Cr-Commit-Position: refs/heads/master@{#381112}