third_party/WebKit/Source/core/inspector/PageConsoleAgent.h - Issue 1774323002: [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

Issue 1774323002: [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed leaks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h b/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

index 2d863a90719338ce2c7e9c2aafca3bbc97f39bba..f61d39787984adb59c1e86f6cdbb8fc68ff7a650 100644

--- a/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

+++ b/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

@@ -58,8 +58,7 @@ public:

void disable(ErrorString*) override;

void workerTerminated(WorkerInspectorProxy*);

- void workerConsoleAgentEnabled(WorkerGlobalScopeProxy*);

+ void workerConsoleAgentEnabled(WorkerInspectorProxy*);

protected:

ConsoleMessageStorage* messageStorage() override;

@@ -73,7 +72,8 @@ private:

RawPtrWillBeMember<InspectorDOMAgent> m_inspectorDOMAgent;

RawPtrWillBeMember<InspectedFrames> m_inspectedFrames;

- HashSet<WorkerGlobalScopeProxy*> m_workersWithEnabledConsole;

+ using WorkerInspectorProxySet = WillBeHeapHashSet<RawPtrWillBeMember<WorkerInspectorProxy>>;

+ WorkerInspectorProxySet m_workersWithEnabledConsole;

static int s_enabledAgentCount;

};