third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp - Issue 1774323002: [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp

Issue 1774323002: [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed leaks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h ('k') | third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp b/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp

index 46cab5965115bbdcc3bc8258d0b6b7b8690525a3..327c361ceb88f23b90b333496ac006f1ab952c6a 100644

--- a/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp

+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp

@@ -51,11 +51,11 @@ Vector<unsigned> ConsoleMessageStorage::argumentCounts() const

return result;

}

-void ConsoleMessageStorage::adoptWorkerMessagesAfterTermination(WorkerGlobalScopeProxy* workerGlobalScopeProxy)

+void ConsoleMessageStorage::adoptWorkerMessagesAfterTermination(WorkerInspectorProxy* workerInspectorProxy)

{

for (size_t i = 0; i < m_messages.size(); ++i) {

- if (m_messages[i]->workerGlobalScopeProxy() == workerGlobalScopeProxy)

- m_messages[i]->setWorkerGlobalScopeProxy(nullptr);

+ if (m_messages[i]->workerInspectorProxy() == workerInspectorProxy)

+ m_messages[i]->setWorkerInspectorProxy(nullptr);

}