Re-use NoUnderlineClickableSpan which shows a clickable link with underlines turned off

Re-use NoUnderlineClickableSpan which shows a clickable link with underlines turned off

A new class NoUnderlineClickableSpan which shows a
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This patch modified code which can re-use this class.

BUG=593547
Committed: https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29
Cr-Commit-Position: refs/heads/master@{#383359}

[juncai, 2016-03-10 00:59:14]

Description was changed from

==========
Use NoUnderlineClickableSpan

Since a new class NoUnderlineClickableSpan was added, this patch modified
code which can use it.

BUG=
==========

to

==========
Use NoUnderlineClickableSpan

Since a new class NoUnderlineClickableSpan was added, this patch modified
code which can use it.

BUG=593547
==========

[juncai, 2016-03-10 01:00:27]

Description was changed from

==========
Use NoUnderlineClickableSpan

Since a new class NoUnderlineClickableSpan was added, this patch modified
code which can use it.

BUG=593547
==========

to

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a clickable link with
underlines turned off was added in patch:
https://codereview.chromium.org/1739523002/

This this patch modified code which can re-use this class.

BUG=593547
==========

[juncai, 2016-03-10 01:01:00]

Description was changed from

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a clickable link with
underlines turned off was added in patch:
https://codereview.chromium.org/1739523002/

This this patch modified code which can re-use this class.

BUG=593547
==========

to

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a 
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This this patch modified code which can re-use this class.

BUG=593547
==========

[juncai, 2016-03-10 01:36:46]

juncai@chromium.org changed reviewers:
+ newt@chromium.org

[juncai, 2016-03-10 01:36:46]

Please take a look.

[juncai, 2016-03-10 01:37:24]

Description was changed from

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a 
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This this patch modified code which can re-use this class.

BUG=593547
==========

to

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a 
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This patch modified code which can re-use this class.

BUG=593547
==========

[newt (away), 2016-03-10 02:45:14]

Thanks for this follow-up. A few comments about ways we can clean things up even
more.

As much as possible, we should be using the same link color throughout Chrome
UI. Typically, the link color is controlled at the Activity level by setting the
value of "android:textColorLink" in the theme (see
chrome/android/java/res/values-v17/styles.xml for an example). You can also
change the link color of an individual TextView by setting that attribute on the
text view.

So, we shouldn't generally need to override the text color in updateDrawState().

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java
(right):

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java:154:
public void updateDrawState(TextPaint textPaint) {
Let's remove this method and delete password_generation_link_text_color from
colors.xml. We should use our color palette consistently, rather than changing
the link color in this one place.

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
(right):

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java:68:
int linkColor = getResources().getColor(R.color.ui_link_text_color);
Get rid of linkColor and delete the FreClickableSpan class altogether. This is
redundant work: we're overriding the color to the default link color.

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
(right):

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java:497:
public void updateDrawState(TextPaint textPaint) {
Remove this method. Again, we shouldn't need to override the link color here.

[juncai, 2016-03-11 23:53:05]

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java
(right):

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java:154:
public void updateDrawState(TextPaint textPaint) {
On 2016/03/10 02:45:13, newt (OOO 3-11) wrote:
> Let's remove this method and delete password_generation_link_text_color from
> colors.xml. We should use our color palette consistently, rather than changing
> the link color in this one place.

Done.

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
(right):

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java:68:
int linkColor = getResources().getColor(R.color.ui_link_text_color);
On 2016/03/10 02:45:14, newt (OOO 3-11) wrote:
> Get rid of linkColor and delete the FreClickableSpan class altogether. This is
> redundant work: we're overriding the color to the default link color.

Done.

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
(right):

https://codereview.chromium.org/1774243003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java:497:
public void updateDrawState(TextPaint textPaint) {
On 2016/03/10 02:45:14, newt (OOO 3-11) wrote:
> Remove this method. Again, we shouldn't need to override the link color here.

Done.

[newt (away), 2016-03-13 21:44:06]

lgtm thanks!

[juncai, 2016-03-25 20:58:23]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-03-25 20:58:24]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1774243003/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-25 20:58:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774243003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774243003/140001

[commit-bot: I haz the power, 2016-03-25 21:07:28]

Description was changed from

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a 
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This patch modified code which can re-use this class.

BUG=593547
==========

to

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a 
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This patch modified code which can re-use this class.

BUG=593547
==========

[commit-bot: I haz the power, 2016-03-25 21:07:29]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-25 21:08:53]

Description was changed from

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a 
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This patch modified code which can re-use this class.

BUG=593547
==========

to

==========
Re-use NoUnderlineClickableSpan which shows a clickable link with underlines
turned off

A new class NoUnderlineClickableSpan which shows a
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This patch modified code which can re-use this class.

BUG=593547

Committed: https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29
Cr-Commit-Position: refs/heads/master@{#383359}
==========

[commit-bot: I haz the power, 2016-03-25 21:08:54]

Patchset 8 (id:??) landed as
https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29
Cr-Commit-Position: refs/heads/master@{#383359}