Re-use NoUnderlineClickableSpan which shows a clickable link with underlines turned off

chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.autofill;
 
 import android.content.Context;
 import android.text.SpannableString;
 import android.text.Spanned;
 import android.text.TextPaint;
 import android.text.method.LinkMovementMethod;
-import android.text.style.ClickableSpan;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View.MeasureSpec;
 import android.view.ViewGroup;
 import android.widget.BaseAdapter;
 import android.widget.RelativeLayout.LayoutParams;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.chrome.R;
+import org.chromium.ui.text.NoUnderlineClickableSpan;
 
 import java.util.Arrays;
 import java.util.List;
 
 /**
  * The adapter that populates the list popup for password generation with data. If the constructor
  * parameter passwordDisplayed is true, then this adapter makes the popup display two items in the
  * list: (1) the password suggestion and (2) an explanation of the password generation feature. If
  * the passwordDisplayed parameter is false, then the adapter shows only the explanation item.
  */
@@ skipping 104 matching lines @@
                 ((TextView) view.findViewById(R.id.password_generation_password))
                         .setText(mPassword);
                 break;
 
             case EXPLANATION:
                 view = inflater.inflate(R.layout.password_generation_popup_explanation, null);
                 TextView explanation = (TextView) view
                         .findViewById(R.id.password_generation_explanation);
                 SpannableString explanationSpan = new SpannableString(mExplanationText);
                 explanationSpan.setSpan(
-                        new ClickableSpan() {
+                        new NoUnderlineClickableSpan() {
                             @Override
                             public void onClick(View view) {
                                 mDelegate.onSavedPasswordsLinkClicked();
                             }
 
                             @Override
                             public void updateDrawState(TextPaint textPaint) {

[newt (away), 2016/03/10 02:45:13]

Let's remove this method and delete password_generation_link_text_color from
colors.xml. We should use our color palette consistently, rather than changing
the link color in this one place.

[juncai, 2016/03/11 23:53:05]

Done.

-                                textPaint.setUnderlineText(false);
+                                super.updateDrawState(textPaint);
                                 textPaint.setColor(ApiCompatibilityUtils.getColor(
                                         mContext.getResources(),
                                         R.color.password_generation_link_text_color));
                             }
-                        }, mExplanationTextLinkRangeStart, mExplanationTextLinkRangeEnd,
+                        },
+                        mExplanationTextLinkRangeStart, mExplanationTextLinkRangeEnd,
                         Spanned.SPAN_INCLUSIVE_INCLUSIVE);
                 explanation.setText(explanationSpan);
                 explanation.setMovementMethod(LinkMovementMethod.getInstance());
                 explanation.setLayoutParams(new LayoutParams(mSuggestionMeasuredWidth,
                         LayoutParams.WRAP_CONTENT));
                 break;
 
             default:
                 assert false : "Unknown view type";
                 break;
@@ skipping 63 matching lines @@
     /**
      * Used by list popup window to check if the element at this position is enabled. Only the
      * suggestion element is enabled.
      * @return boolean True if the view at position is a suggestion.
      */
     @Override
     public boolean isEnabled(int position) {
         return mViewTypes.get(position) == SUGGESTION;
     }
 }