Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4464)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java

Issue 1774243003: Re-use NoUnderlineClickableSpan which shows a clickable link with underlines turned off (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webusb_android_chooser
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
index 43bc84f99062b941e61d9bf3dd1f1de0d51db56a..704b8e18f403dda16266a2a405a7257c5a871d31 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.tab;
import android.content.Context;
import android.text.method.LinkMovementMethod;
-import android.text.style.ClickableSpan;
import android.view.LayoutInflater;
import android.view.View;
import android.view.View.OnClickListener;
@@ -14,6 +13,7 @@ import android.widget.Button;
import android.widget.TextView;
import org.chromium.chrome.R;
+import org.chromium.ui.text.NoUnderlineClickableSpan;
import org.chromium.ui.text.SpanApplier;
import org.chromium.ui.text.SpanApplier.SpanInfo;
@@ -56,18 +56,11 @@ public class SadTabViewFactory {
Context context, final OnClickListener suggestionAction) {
String helpMessage = context.getString(R.string.sad_tab_message)
+ "\n\n" + context.getString(R.string.sad_tab_suggestions);
- ClickableSpan span = new ClickableSpan() {
+ NoUnderlineClickableSpan span = new NoUnderlineClickableSpan() {
@Override
public void onClick(View view) {
suggestionAction.onClick(view);
}
-
- // Disable underline on the link text.
- @Override
- public void updateDrawState(android.text.TextPaint textPaint) {
- super.updateDrawState(textPaint);
- textPaint.setUnderlineText(false);
- }
};
return SpanApplier.applySpans(helpMessage, new SpanInfo("<link>", "</link>", span));
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698