Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: Source/core/css/CSSKeyframesRule.cpp

Issue 177423010: Oilpan: Remove Persistent handles from heap allocated CSSRule objects and fix finalization of CSSKe… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Keep the size assertion turned on. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSKeyframesRule.cpp
diff --git a/Source/core/css/CSSKeyframesRule.cpp b/Source/core/css/CSSKeyframesRule.cpp
index 09fd04e845f753d69f14c230d09674ef8acbaec5..ce8fc273ea25b72d15cdf072570074675a3d1d74 100644
--- a/Source/core/css/CSSKeyframesRule.cpp
+++ b/Source/core/css/CSSKeyframesRule.cpp
@@ -98,10 +98,12 @@ CSSKeyframesRule::~CSSKeyframesRule()
{
ASSERT(m_childRuleCSSOMWrappers.size() == m_keyframesRule->keyframes().size());
+#if !ENABLE(OILPAN)
for (unsigned i = 0; i < m_childRuleCSSOMWrappers.size(); ++i) {
if (m_childRuleCSSOMWrappers[i])
m_childRuleCSSOMWrappers[i]->setParentRule(0);
}
+#endif
}
void CSSKeyframesRule::setName(const String& name)
@@ -207,8 +209,9 @@ void CSSKeyframesRule::trace(Visitor* visitor)
{
CSSRule::trace(visitor);
#if ENABLE(OILPAN)
wibling-chromium 2014/03/03 10:08:40 NIT: Do we still need the if? I thought we could h
- m_childRuleCSSOMWrappers.trace(visitor);
+ visitor->trace(m_childRuleCSSOMWrappers);
#endif
+ visitor->trace(m_keyframesRule);
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698