Oilpan: Remove Persistent handles from heap allocated CSSRule objects and fix finalization of CSSKe…

Source/core/css/CSSKeyframesRule.cpp

 /*
  * Copyright (C) 2007, 2008, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 80 matching lines @@
     , m_keyframesRule(keyframesRule)
     , m_childRuleCSSOMWrappers(keyframesRule->keyframes().size())
     , m_isPrefixed(keyframesRule->isVendorPrefixed())
 {
 }
 
 CSSKeyframesRule::~CSSKeyframesRule()
 {
     ASSERT(m_childRuleCSSOMWrappers.size() == m_keyframesRule->keyframes().size());
 
+#if !ENABLE(OILPAN)
     for (unsigned i = 0; i < m_childRuleCSSOMWrappers.size(); ++i) {
         if (m_childRuleCSSOMWrappers[i])
             m_childRuleCSSOMWrappers[i]->setParentRule(0);
     }
+#endif
 }
 
 void CSSKeyframesRule::setName(const String& name)
 {
     CSSStyleSheet::RuleMutationScope mutationScope(this);
 
     m_keyframesRule->setName(name);
 }
 
 void CSSKeyframesRule::insertRule(const String& ruleText)
@@ skipping 84 matching lines @@
 
 void CSSKeyframesRule::reattach(StyleRuleBase* rule)
 {
     ASSERT(rule);
     m_keyframesRule = toStyleRuleKeyframes(rule);
 }
 
 void CSSKeyframesRule::trace(Visitor* visitor)
 {
     CSSRule::trace(visitor);
 #if ENABLE(OILPAN)

[wibling-chromium, 2014/03/03 10:08:40]

NIT: Do we still need the if? I thought we could handle tracing of Vector<RefPtr
<> >?

-    m_childRuleCSSOMWrappers.trace(visitor);
+    visitor->trace(m_childRuleCSSOMWrappers);
 #endif
+    visitor->trace(m_keyframesRule);
 }
 
 } // namespace WebCore