Oilpan: Remove Persistent handles from heap allocated CSSRule objects and fix finalization of CSSKe…

Source/core/css/CSSFilterRule.cpp

Index: Source/core/css/CSSFilterRule.cpp
diff --git a/Source/core/css/CSSFilterRule.cpp b/Source/core/css/CSSFilterRule.cpp
index 0ea5f177a5d34f59c186f8027f7b8a4665a8f35a..873d87de44c68e7e4973f31df7c591453d50515b 100644
--- a/Source/core/css/CSSFilterRule.cpp
+++ b/Source/core/css/CSSFilterRule.cpp
@@ -82,5 +82,11 @@ void CSSFilterRule::reattach(StyleRuleBase* rule)
         m_propertiesCSSOMWrapper->reattach(m_filterRule->mutableProperties());
 }
 
+void CSSFilterRule::trace(Visitor* visitor)
+{
+    CSSRule::trace(visitor);

[wibling-chromium, 2014/03/03 10:08:40]

NIT: Don't we tend to do this last to make it a tail call?

[haraken, 2014/03/03 10:39:35]

Nit: I want to know this. We sometimes write ParentClass::trace at the head and
sometimes write it at the tail. There is no consistency so far.

[Mads Ager (chromium), 2014/03/03 10:40:40]

I honestly don't care as long as the call is there. We should do a sweeping
change to put it either first or last. :-)

[tkent, 2014/03/03 23:55:55]

As wibling wrote, tail calls are better in general because a compiler can
optimize them to jump instructions.

+    visitor->trace(m_filterRule);
+}
+
 } // namespace WebCore