xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h - Issue 1773733002: Review and cleanup lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h ('K') | « xfa/src/fxbarcode/oned/BC_OnedCodaBarWriter.h ('k') | xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h

diff --git a/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h b/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h

index a99c0e89f8d9fb04bef14dfb3931720c8e62aa9d..db1f8e3ad32ecad6b23c21e3bd4b6eb87067c982 100644

--- a/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h

+++ b/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h

@@ -17,24 +17,24 @@ class CBC_OnedCode128Reader : public CBC_OneDReader {

CBC_CommonBitArray* row,

int32_t hints,

int32_t& e);

- const static int32_t CODE_PATTERNS[107][7];

- const static int32_t MAX_AVG_VARIANCE;

- const static int32_t MAX_INDIVIDUAL_VARIANCE;

+ static const int32_t CODE_PATTERNS[107][7];

+ static const int32_t MAX_AVG_VARIANCE;

Tom Sepez 2016/03/08 19:27:06 etc.

dsinclair 2016/03/08 21:08:03 Done.

+ static const int32_t MAX_INDIVIDUAL_VARIANCE;

- const static int32_t CODE_SHIFT;

- const static int32_t CODE_CODE_C;

- const static int32_t CODE_CODE_B;

- const static int32_t CODE_CODE_A;

- const static int32_t CODE_FNC_1;

- const static int32_t CODE_FNC_2;

- const static int32_t CODE_FNC_3;

- const static int32_t CODE_FNC_4_A;

- const static int32_t CODE_FNC_4_B;

+ static const int32_t CODE_SHIFT;

+ static const int32_t CODE_CODE_C;

+ static const int32_t CODE_CODE_B;

+ static const int32_t CODE_CODE_A;

+ static const int32_t CODE_FNC_1;

+ static const int32_t CODE_FNC_2;

+ static const int32_t CODE_FNC_3;

+ static const int32_t CODE_FNC_4_A;

+ static const int32_t CODE_FNC_4_B;

- const static int32_t CODE_START_A;

- const static int32_t CODE_START_B;

- const static int32_t CODE_START_C;

- const static int32_t CODE_STOP;

+ static const int32_t CODE_START_A;

+ static const int32_t CODE_START_B;

+ static const int32_t CODE_START_C;

+ static const int32_t CODE_STOP;

private:

CFX_Int32Array* FindStartPattern(CBC_CommonBitArray* row, int32_t& e);