Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1926)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/src/fxbarcode/oned/BC_OneDimReader.h ('K') | « xfa/src/fxbarcode/oned/BC_OneDimReader.h ('k') | xfa/src/fxbarcode/oned/BC_OnedCodaBarWriter.h » ('j') | xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h
diff --git a/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h b/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h
index cbb47fb55465f5de4cc4f10e2340bf5183097666..463efc67fc99892645f53331ee0932d05ff6dc6a 100644
--- a/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h
+++ b/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h
@@ -25,12 +25,9 @@ class CBC_OnedCodaBarReader : public CBC_OneDReader {
FX_BOOL ArrayContains(const FX_CHAR array[], FX_CHAR key);
FX_CHAR ToNarrowWidePattern(CFX_Int32Array* counter);
static const FX_CHAR* ALPHABET_STRING;
Tom Sepez 2016/03/08 19:27:06 can these be private? Same issues.
dsinclair 2016/03/08 21:08:03 Done.
-
- const static int32_t CHARACTER_ENCODINGS[22];
-
- const static int32_t minCharacterLength;
-
- const static FX_CHAR STARTEND_ENCODING[8];
+ static const int32_t CHARACTER_ENCODINGS[22];
+ static const int32_t minCharacterLength;
+ static const FX_CHAR STARTEND_ENCODING[8];
};
#endif // XFA_SRC_FXBARCODE_ONED_BC_ONEDCODABARREADER_H_
« xfa/src/fxbarcode/oned/BC_OneDimReader.h ('K') | « xfa/src/fxbarcode/oned/BC_OneDimReader.h ('k') | xfa/src/fxbarcode/oned/BC_OnedCodaBarWriter.h » ('j') | xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698