xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp - Issue 1773733002: Review and cleanup lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

diff --git a/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp b/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

index 582f93bc152e1dd3ddc5a2786b1b3e7466c1d425..ba20f51a532b3ea4e29c5f0e4a5a307239eee050 100644

--- a/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

+++ b/xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

@@ -306,6 +306,7 @@ CFX_ByteString CBC_OnedCode128Reader::DecodeRow(int32_t rowNumber,

result += '0';

}

FX_CHAR temp[128];

+// TODO(dsinclair): Should this be snprintf?

#if defined(_FX_WINAPI_PARTITION_APP_)

sprintf_s(temp, 128, "%d", code);

#else