Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 // Original code is licensed as follows: 6 // Original code is licensed as follows:
7 /* 7 /*
8 * Copyright 2008 ZXing authors 8 * Copyright 2008 ZXing authors
9 * 9 *
10 * Licensed under the Apache License, Version 2.0 (the "License"); 10 * Licensed under the Apache License, Version 2.0 (the "License");
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 break; 299 break;
300 } 300 }
301 } 301 }
302 break; 302 break;
303 case 99: 303 case 99:
304 if (code < 100) { 304 if (code < 100) {
305 if (code < 10) { 305 if (code < 10) {
306 result += '0'; 306 result += '0';
307 } 307 }
308 FX_CHAR temp[128]; 308 FX_CHAR temp[128];
309 // TODO(dsinclair): Should this be snprintf?
309 #if defined(_FX_WINAPI_PARTITION_APP_) 310 #if defined(_FX_WINAPI_PARTITION_APP_)
310 sprintf_s(temp, 128, "%d", code); 311 sprintf_s(temp, 128, "%d", code);
311 #else 312 #else
312 sprintf(temp, "%d", code); 313 sprintf(temp, "%d", code);
313 #endif 314 #endif
314 result += temp; 315 result += temp;
315 } else { 316 } else {
316 if (code != CODE_STOP) { 317 if (code != CODE_STOP) {
317 lastCharacterWasPrintable = FALSE; 318 lastCharacterWasPrintable = FALSE;
318 } 319 }
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 } else { 361 } else {
361 result = result.Mid(0, result.GetLength() - 1); 362 result = result.Mid(0, result.GetLength() - 1);
362 } 363 }
363 } 364 }
364 if (result.GetLength() == 0) { 365 if (result.GetLength() == 0) {
365 e = BCExceptionFormatException; 366 e = BCExceptionFormatException;
366 return ""; 367 return "";
367 } 368 }
368 return result; 369 return result;
369 } 370 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698