Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Issue 1773683002: Remove -f and swap -s flag from nm call in verify_order. (Closed)

Created:
4 years, 9 months ago by justincohen
Modified:
4 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove -f and swap -s flag from nm call in verify_order. Xcode 7.3 changed the flags for nm, but removing -f and swapping the order of -s makes it work for both pre-7.3 and 7.3. BUG= Committed: https://crrev.com/2034c17e1b8a17785b55f32c4f34512e15c4032d Cr-Commit-Position: refs/heads/master@{#382570}

Patch Set 1 #

Patch Set 2 : Also swap -s segname flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/tools/build/mac/verify_order View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
justincohen
Any ideas on how to test this more completely, other than git try ? PTAL
4 years, 9 months ago (2016-03-07 18:27:22 UTC) #3
Nico
lgtm if you checked locally than -f doesn't make a difference on nm's output with ...
4 years, 9 months ago (2016-03-10 22:46:49 UTC) #4
Nico
...and thanks!
4 years, 9 months ago (2016-03-10 22:46:55 UTC) #5
justincohen
I waited for Xcode 7.3 to run another test and had to swap the -s ...
4 years, 9 months ago (2016-03-22 01:31:04 UTC) #6
Nico
Lgtm I'm surprised patch set 2 is necessary.
4 years, 9 months ago (2016-03-22 02:22:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773683002/20001
4 years, 9 months ago (2016-03-22 13:59:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 14:40:28 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 14:41:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2034c17e1b8a17785b55f32c4f34512e15c4032d
Cr-Commit-Position: refs/heads/master@{#382570}

Powered by Google App Engine
This is Rietveld 408576698