chrome/tools/build/mac/verify_order - Issue 1773683002: Remove -f and swap -s flag from nm call in verify_order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/build/mac/verify_order

Issue 1773683002: Remove -f and swap -s flag from nm call in verify_order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also swap -s segname flag Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/tools/build/mac/verify_order

diff --git a/chrome/tools/build/mac/verify_order b/chrome/tools/build/mac/verify_order

index cfa4c5a28e30168d99c10c05001442bd02126daf..d10ca9d4b33802a65244b12cebd12fd0047c173f 100755

--- a/chrome/tools/build/mac/verify_order

+++ b/chrome/tools/build/mac/verify_order

@@ -23,7 +23,7 @@ fi

LAST_SYMBOL=${1}

MACH_O_FILE=${2}

-SYMBOLS=$(nm -fgjn -s __TEXT __text "${MACH_O_FILE}")

+SYMBOLS=$(nm -gjn "${MACH_O_FILE}" -s __TEXT __text)

if [ ${?} -ne 0 ] || [ -z "${SYMBOLS}" ] ; then

echo "${0}: no symbols in ${MACH_O_FILE}" >& 2

exit 1

« no previous file with comments | « no previous file | no next file » | no next file with comments »