Issue 177243002: Remove unused WebPrivatePtr::operator=(std::nullptr_t).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177243002: Remove unused WebPrivatePtr::operator=(std::nullptr_t). (Closed)

Created:
6 years, 10 months ago by sof

Modified:
6 years, 10 months ago

Reviewers:
oilpan-reviews, jochen (gone - plz use gerrit), abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove unused WebPrivatePtr::operator=(std::nullptr_t). With std::nullptr_t constructors in place for the various Ptr types, this method is no longer needed. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167690

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	public/platform/WebPrivatePtr.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 6 (0 generated)

sof

Please take a look. Relanding https://codereview.chromium.org/173713008, as its use of nullptr in platform code ran ...

6 years, 10 months ago (2014-02-24 08:50:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/177243002/1

6 years, 10 months ago (2014-02-24 08:57:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/177243002/1

6 years, 10 months ago (2014-02-24 13:32:40 UTC) #5

Message was sent while issue was closed.

Change committed as 167690