Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 173713008: Remove unused WebPrivatePtr::operator=(std::nullptr_t). (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, jsbell, alecflett, abarth-chromium, dglazkov+blink, dgrogan, cmumford
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused WebPrivatePtr::operator=(std::nullptr_t). With std::nullptr_t constructors in place for the various Ptr types, this method is no longer needed. Also revert some reset() uses that were introduced while waiting for the same nullptr change to land. R=abarth@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/web/WebIDBKey.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebIDBKeyRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebPrivatePtr.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
Please take a look. With nullptr(_t) changes safely landed, following up on some WebPrivatePtr details.
6 years, 10 months ago (2014-02-21 11:47:50 UTC) #1
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-21 17:37:24 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-21 17:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/173713008/1
6 years, 10 months ago (2014-02-21 17:40:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:23:43 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:23:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:24:00 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:24:01 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-21 19:14:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/173713008/1
6 years, 10 months ago (2014-02-21 19:14:14 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 20:29:59 UTC) #11
Message was sent while issue was closed.
Change committed as 167612

Powered by Google App Engine
This is Rietveld 408576698