Issue 169763006: Revert 167612 "Remove unused WebPrivatePtr::operator=(std::nullp..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 169763006: Revert 167612 "Remove unused WebPrivatePtr::operator=(std::nullp..." (Closed)

Created:
6 years, 10 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 10 months ago

Reviewers:
sof

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 167612 "Remove unused WebPrivatePtr::operator=(std::nullp..." Results in undefined symbol on Linux. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/17859 > Remove unused WebPrivatePtr::operator=(std::nullptr_t). > > With std::nullptr_t constructors in place for the various Ptr types, > this method is no longer needed. > > Also revert some reset() uses that were introduced while waiting for > the same nullptr change to land. > > R=abarth@chromium.org > BUG= > > Review URL: https://codereview.chromium.org/173713008 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167615

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -2 lines)			Patch
M	trunk/Source/web/WebIDBKey.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/web/WebIDBKeyRange.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/public/platform/WebPrivatePtr.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

acolwell GONE FROM CHROMIUM

Committed patchset #1 manually as r167615.

6 years, 10 months ago (2014-02-21 22:51:17 UTC) #2

sof

6 years, 10 months ago (2014-02-22 09:00:39 UTC) #3

Message was sent while issue was closed.

Thanks acolwell, sorry about this.

I will have to understand why the nullptr conversion doesn't happen in this
setting, clearly.