Mojo: Include "path/to/foo.mojom.h"

Mojo: Include "path/to/foo.mojom.h"

Given path/to/foo.mojom, change the code generator to output:

  <(SHARED_INTERMEDIATE_DIR)/path/to/foo.mojom.cc
  <(SHARED_INTERMEDIATE_DIR)/path/to/foo.mojom.h
  <(SHARED_INTERMEDIATE_DIR)/path/to/foo.mojom-internal.h

This involves shelling out to a python script to compute "path/to" part as that is not otherwise available from GYP. See build/inverse_depth.py.

DEPTH is now passed to mojom_bindings_generator.py so that it can similarly compute "path/to". With that, we no longer need the include_dir argument, so I dropped it.

R=davemoore@chromium.org, mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253937

[darin (slow to review), 2014-02-27 06:33:58]

Mark- please review build/inverse_depth.py

Dave- please review the rest

[Mark Mentovai, 2014-02-27 14:10:32]

LGTM. I only reviewed build/inverse_depth.py.

https://codereview.chromium.org/177183002/diff/110001/build/inverse_depth.py
File build/inverse_depth.py (right):

https://codereview.chromium.org/177183002/diff/110001/build/inverse_depth.py#...
build/inverse_depth.py:12: return os.path.relpath(os.path.abspath(os.getcwd()),
I can’t envision a reason that os.getcwd() wouldn’t already be an absolute path,
so I don’t think you need this abspath, but you do need the next one around
depth.

Eliminate one abspath and this will all fit on one line, too.

[DaveMoore, 2014-02-27 14:22:14]

lgtm

[darin (slow to review), 2014-02-27 20:45:34]

On 2014/02/27 14:10:32, Mark Mentovai wrote:
> LGTM. I only reviewed build/inverse_depth.py.
> 
> https://codereview.chromium.org/177183002/diff/110001/build/inverse_depth.py
> File build/inverse_depth.py (right):
> 
>
https://codereview.chromium.org/177183002/diff/110001/build/inverse_depth.py#...
> build/inverse_depth.py:12: return
os.path.relpath(os.path.abspath(os.getcwd()),
> I can’t envision a reason that os.getcwd() wouldn’t already be an absolute
path,
> so I don’t think you need this abspath, but you do need the next one around
> depth.
> 
> Eliminate one abspath and this will all fit on one line, too.

Yup, good catch. Thanks!

[darin (slow to review), 2014-02-27 22:07:55]

Committed patchset #7 manually as r253937 (presubmit successful).