Removed AttemptResult enum in favor of using DefaultWebClientState

Removed AttemptResult enum in favor of using DefaultWebClientState

This simplifies the code and makes it consistent across different OS.

Committed: https://crrev.com/60a702cce038f3acd793496b9dabc792e28fc912
Cr-Commit-Position: refs/heads/master@{#382720}

[Patrick Monette, 2016-03-08 23:58:54]

Patchset #1 (id:1) has been deleted

[Patrick Monette, 2016-03-09 00:00:48]

pmonette@chromium.org changed reviewers:
+ grt@chromium.org

[Patrick Monette, 2016-03-09 00:00:49]

Hey Greg. PTAL. This will facilitate the change to make metrics work for the
Win10 flow of opening the settings page.

[grt (UTC plus 2), 2016-03-10 20:03:57]

Is there anything of value being reported via AttemptResult that won't be
reported via DefaultWebClientState?

[Patrick Monette, 2016-03-16 17:28:19]

On 2016/03/10 20:03:57, grt (very slow) wrote:
> Is there anything of value being reported via AttemptResult that won't be
> reported via DefaultWebClientState?

Well currently nothing as this code doesn't even run with the async flow
disabled.

What we'd probably want to keep:
LAUNCH_FAILURE: We want to know if we managed to open the Windows settings page.
RETRY: During the 2 minutes timeout, the user clicked again on "Set Default
Browser".

These should easily be movable to another histogram.

[grt (UTC plus 2), 2016-03-18 13:39:27]

lgtm

https://codereview.chromium.org/1770943005/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1770943005/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:7451: +<histogram
name="DefaultBrowser.SetDefaultResult2" enum="DefaultWebClientState">
is it appropriate to use histogram_suffixes to define the pair of histograms?

https://codereview.chromium.org/1770943005/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62814: +    Chrome is in a unknown
default state
nit: period at end of sentence

[Patrick Monette, 2016-03-18 21:39:10]

pmonette@chromium.org changed reviewers:
+ asvitkine@chromium.org, sky@chromium.org

[Patrick Monette, 2016-03-18 21:39:10]

sky@ PTAL
asvitkine@ Please review histograms.xml + question from grt@

https://codereview.chromium.org/1770943005/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1770943005/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:7451: +<histogram
name="DefaultBrowser.SetDefaultResult2" enum="DefaultWebClientState">
On 2016/03/18 13:39:27, grt (very slow) wrote:
> is it appropriate to use histogram_suffixes to define the pair of histograms?

Good question. asvitkine@?

https://codereview.chromium.org/1770943005/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62814: +    Chrome is in a unknown
default state
On 2016/03/18 13:39:27, grt (very slow) wrote:
> nit: period at end of sentence

Done.

[sky, 2016-03-21 16:50:48]

LGTM

[Alexei Svitkine (slow), 2016-03-21 19:38:46]

lgtm

[Patrick Monette, 2016-03-22 21:27:20]

Patchset #5 (id:100001) has been deleted

[Patrick Monette, 2016-03-22 21:27:25]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-03-22 21:27:26]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org,
asvitkine@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1770943005/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-22 21:28:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770943005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770943005/120001

[commit-bot: I haz the power, 2016-03-22 22:59:52]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-03-22 23:01:32]

Description was changed from

==========
Removed AttemptResult enum in favor of using DefaultWebClientState

This simplifies the code and makes it consistent across different OS.
==========

to

==========
Removed AttemptResult enum in favor of using DefaultWebClientState

This simplifies the code and makes it consistent across different OS.

Committed: https://crrev.com/60a702cce038f3acd793496b9dabc792e28fc912
Cr-Commit-Position: refs/heads/master@{#382720}
==========

[commit-bot: I haz the power, 2016-03-22 23:01:33]

Patchset 5 (id:??) landed as
https://crrev.com/60a702cce038f3acd793496b9dabc792e28fc912
Cr-Commit-Position: refs/heads/master@{#382720}