Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1770943005: Removed AttemptResult enum in favor of using DefaultWebClientState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dont_record_async_duration
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/shell_integration.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 7e1f83d44aa860cd1406256479f13b77e66f5e1e..402b3fba735fc65107621230265e8ce91bd0c38d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -7459,6 +7459,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="DefaultBrowser.SetDefaultResult"
enum="SetDefaultAttemptResult">
+ <obsolete>
+ Deprecated 2016/03.
+ </obsolete>
+ <owner>pmonette@chromium.org</owner>
+ <summary>
+ The outcome of an attempt to set Chrome as the user's default browser.
+ </summary>
+</histogram>
+
+<histogram name="DefaultBrowser.SetDefaultResult2" enum="DefaultWebClientState">
<owner>pmonette@chromium.org</owner>
<summary>
The outcome of an attempt to set Chrome as the user's default browser.
@@ -7535,6 +7545,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="DefaultProtocolClient.SetDefaultResult"
enum="SetDefaultAttemptResult">
+ <obsolete>
+ Deprecated 2016/03.
+ </obsolete>
+ <owner>pmonette@chromium.org</owner>
+ <summary>
+ The outcome of an attempt to set Chrome as the user's default client for a
+ protocol.
+ </summary>
+</histogram>
+
+<histogram name="DefaultProtocolClient.SetDefaultResult2"
+ enum="DefaultWebClientState">
<owner>pmonette@chromium.org</owner>
<summary>
The outcome of an attempt to set Chrome as the user's default client for a
@@ -63140,6 +63162,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="8" label="DSP set to new engine with no previous value in prefs"/>
</enum>
+<enum name="DefaultWebClientState" type="int">
+ <int value="0" label="Not default">Chrome is not the default web client.</int>
+ <int value="1" label="Is default">Chrome is the default web client.</int>
+ <int value="2" label="Unknown default">
+ Chrome is in a unknown default state.
+ </int>
+</enum>
+
<enum name="DelayBasedEchoQuality" type="int">
<int value="0" label="Good delays">
Echo Cancellation quality most likely good.
@@ -80762,6 +80792,9 @@ To add a new entry, add it with any value and run test to compute valid value.
</enum>
<enum name="SetDefaultAttemptResult" type="int">
+ <obsolete>
+ Deprecated 2016/03. Replaced by DefaultWebClientState.
+ </obsolete>
<int value="0" label="Success">Chrome was set as the default web client.</int>
<int value="1" label="Already default">
Chrome was already the default web client. This counts as a successful
« no previous file with comments | « chrome/browser/shell_integration.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698