Chromium Code Reviews Chromium Code Reviews
Issue 1770943005:
Removed AttemptResult enum in favor of using DefaultWebClientState (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@dont_record_async_duration| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 16f652cd549a44987968012f681f9d131fa3f199..2191b780bf717edb3931b96ae8ca587c4322aff7 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -7439,6 +7439,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="DefaultBrowser.SetDefaultResult" |
| enum="SetDefaultAttemptResult"> |
| + <obsolete> |
| + Deprecated 2016/03. |
| + </obsolete> |
| + <owner>pmonette@chromium.org</owner> |
| + <summary> |
| + The outcome of an attempt to set Chrome as the user's default browser. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DefaultBrowser.SetDefaultResult2" enum="DefaultWebClientState"> |
|
grt (UTC plus 2)
2016/03/18 13:39:27
is it appropriate to use histogram_suffixes to def
Patrick Monette
2016/03/18 21:39:10
Good question. asvitkine@?
|
| <owner>pmonette@chromium.org</owner> |
| <summary> |
| The outcome of an attempt to set Chrome as the user's default browser. |
| @@ -7515,6 +7525,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="DefaultProtocolClient.SetDefaultResult" |
| enum="SetDefaultAttemptResult"> |
| + <obsolete> |
| + Deprecated 2016/03. |
| + </obsolete> |
| + <owner>pmonette@chromium.org</owner> |
| + <summary> |
| + The outcome of an attempt to set Chrome as the user's default client for a |
| + protocol. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="DefaultProtocolClient.SetDefaultResult2" |
| + enum="DefaultWebClientState"> |
| <owner>pmonette@chromium.org</owner> |
| <summary> |
| The outcome of an attempt to set Chrome as the user's default client for a |
| @@ -62785,6 +62807,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="8" label="DSP set to new engine with no previous value in prefs"/> |
| </enum> |
| +<enum name="DefaultWebClientState" type="int"> |
| + <int value="0" label="Not default">Chrome is not the default web client.</int> |
| + <int value="1" label="Is default">Chrome is the default web client.</int> |
| + <int value="2" label="Unknown default"> |
| + Chrome is in a unknown default state |
|
grt (UTC plus 2)
2016/03/18 13:39:27
nit: period at end of sentence
Patrick Monette
2016/03/18 21:39:10
Done.
|
| + </int> |
| +</enum> |
| + |
| <enum name="DelayBasedEchoQuality" type="int"> |
| <int value="0" label="Good delays"> |
| Echo Cancellation quality most likely good. |
| @@ -80350,6 +80380,9 @@ To add a new entry, add it with any value and run test to compute valid value. |
| </enum> |
| <enum name="SetDefaultAttemptResult" type="int"> |
| + <obsolete> |
| + Deprecated 2016/03. Replaced by DefaultWebClientState. |
| + </obsolete> |
| <int value="0" label="Success">Chrome was set as the default web client.</int> |
| <int value="1" label="Already default"> |
| Chrome was already the default web client. This counts as a successful |
