Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 177093013: Move the setting of test options to WillRunTest (Closed)

Created:
6 years, 10 months ago by nduca
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

Move the setting of test options to WillRunTest Test.options was previously unset until RunTest. So, methods that happened on test object before Run() didn't have access to any of the options they'd programmed into the original options parser. This led to a fair bit of grossness in tests that wanted to have options. This patch changes options to be passed in on the WillRun. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M tools/telemetry/telemetry/page/extensions_profile_creator.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 2 chunks +7 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nduca
ptal
6 years, 10 months ago (2014-02-25 05:23:51 UTC) #1
tonyg
lgtm, very nice
6 years, 10 months ago (2014-02-25 05:39:05 UTC) #2
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 10 months ago (2014-02-25 23:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/177093013/1
6 years, 10 months ago (2014-02-26 00:24:11 UTC) #4
nduca
The CQ bit was unchecked by nduca@chromium.org
6 years, 10 months ago (2014-02-26 05:30:43 UTC) #5
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 10 months ago (2014-02-26 05:30:47 UTC) #6
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:32:06 UTC) #7
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:41:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/177093013/1
6 years, 10 months ago (2014-02-26 06:02:30 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 17:50:12 UTC) #10
Message was sent while issue was closed.
Change committed as 253499

Powered by Google App Engine
This is Rietveld 408576698