tools/telemetry/telemetry/page/page_runner.py - Issue 177093013: Move the setting of test options to WillRunTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 177093013: Move the setting of test options to WillRunTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index c57703c3049a2fde652ccc5231f3a3fbeabe2ff9..40dbc6a8c78c646e58dcb66366237847f361e8fe 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -333,7 +333,7 @@ def Run(test, page_set, expectations, finder_options):

# TODO(dtu): Move results creation and results_for_current_run into RunState.

try:

- test.WillRunTest()

+ test.WillRunTest(finder_options)

state.repeat_state = page_runner_repeat.PageRunnerRepeatState(

finder_options.repeat_options)

@@ -458,7 +458,7 @@ def _RunPage(test, page, state, expectation, results, finder_options):

if state.repeat_state.ShouldNavigate(

finder_options.skip_navigate_on_repeat):

page_state.ImplicitPageNavigation(test)

- test.Run(finder_options, page, page_state.tab, results)

+ test.Run(page, page_state.tab, results)

util.CloseConnections(page_state.tab)

except page_test.Failure:

if expectation == 'fail':