Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/telemetry/telemetry/page/extensions_profile_creator.py

Issue 177093013: Move the setting of test options to WillRunTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/extensions_profile_creator.py
diff --git a/tools/telemetry/telemetry/page/extensions_profile_creator.py b/tools/telemetry/telemetry/page/extensions_profile_creator.py
index 4c43774e7070fb943c22ddf54711418870ba667d..4fec966329a2eddaf8d7b06ad8b84fe141b928f3 100644
--- a/tools/telemetry/telemetry/page/extensions_profile_creator.py
+++ b/tools/telemetry/telemetry/page/extensions_profile_creator.py
@@ -154,10 +154,11 @@ class ExtensionsProfileCreator(profile_creator.ProfileCreator):
def CustomizeBrowserOptions(self, options):
self._output_profile_path = options.output_profile_path
- def WillRunTest(self):
+ def WillRunTest(self, options):
"""Run before browser starts.
Download extensions and write installation files."""
+ super(ExtensionsProfileCreator, self).WillRunTest(options)
# Running this script on a corporate network or other managed environment
# could potentially alter the profile contents.
@@ -176,6 +177,7 @@ class ExtensionsProfileCreator(profile_creator.ProfileCreator):
def DidRunTest(self, browser, results):
"""Run before exit."""
+ super(ExtensionsProfileCreator, self).DidRunTest()
# Do some basic sanity checks to make sure the profile is complete.
installed_extensions = browser.extensions.keys()
if not len(installed_extensions) == len(self._extensions_to_install):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698