Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177093002: [IME] Loads chromeos-xkb extension and add the extension based xkb keyboards in the chrome://settin… (Closed)

Created:
6 years, 10 months ago by Shu Chen
Modified:
6 years, 10 months ago
Reviewers:
Seigo Nonaka, Yuki
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[IME] Enables the extension based xkb keyboards in chrome://settings/languages and at login screen. BUG=345604 Test=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253350

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/ime/component_extension_ime_manager.cc View 1 1 chunk +7 lines, -4 lines 2 comments Download
M chromeos/ime/extension_ime_util.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/ime/extension_ime_util.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Shu Chen
Hi Nona/Yuki/Hiro, can you please help to review this cl? Thanks, Shu
6 years, 10 months ago (2014-02-24 14:45:16 UTC) #1
Yuki
lgtm, but I recommend to get reviewed from nona@, too.
6 years, 10 months ago (2014-02-25 06:53:32 UTC) #2
Seigo Nonaka
lgtm lgtm with one comment https://codereview.chromium.org/177093002/diff/110001/chromeos/ime/component_extension_ime_manager.cc File chromeos/ime/component_extension_ime_manager.cc (right): https://codereview.chromium.org/177093002/diff/110001/chromeos/ime/component_extension_ime_manager.cc#newcode145 chromeos/ime/component_extension_ime_manager.cc:145: extension_ime_util::IsKeyboardLayoutExtension(input_method_id), Please making sure ...
6 years, 10 months ago (2014-02-25 06:57:18 UTC) #3
Shu Chen
https://codereview.chromium.org/177093002/diff/110001/chromeos/ime/component_extension_ime_manager.cc File chromeos/ime/component_extension_ime_manager.cc (right): https://codereview.chromium.org/177093002/diff/110001/chromeos/ime/component_extension_ime_manager.cc#newcode145 chromeos/ime/component_extension_ime_manager.cc:145: extension_ime_util::IsKeyboardLayoutExtension(input_method_id), On 2014/02/25 06:57:19, Seigo Nonaka wrote: > Please ...
6 years, 10 months ago (2014-02-25 08:52:50 UTC) #4
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 10 months ago (2014-02-25 08:52:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/177093002/110001
6 years, 10 months ago (2014-02-25 08:53:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/177093002/110001
6 years, 10 months ago (2014-02-25 09:21:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 11:42:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 11:42:14 UTC) #9
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 10 months ago (2014-02-25 13:48:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/177093002/110001
6 years, 10 months ago (2014-02-25 13:50:03 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-25 13:52:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-25 13:52:19 UTC) #13
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 10 months ago (2014-02-25 23:22:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/177093002/110001
6 years, 10 months ago (2014-02-25 23:39:21 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 04:56:02 UTC) #16
Message was sent while issue was closed. 
Change committed as 253350

Powered by Google App Engine
This is Rietveld 408576698