[IME] Loads chromeos-xkb extension and add the extension based xkb keyboards in the chrome://settin…

chromeos/ime/component_extension_ime_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/ime/component_extension_ime_manager.h"
 
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "chromeos/ime/extension_ime_util.h"
 
@@ skipping 112 matching lines @@
     }
   }
   return result;
 }
 
 input_method::InputMethodDescriptors
     ComponentExtensionIMEManager::GetAllIMEAsInputMethodDescriptor() {
   input_method::InputMethodDescriptors result;
   for (size_t i = 0; i < component_extension_imes_.size(); ++i) {
     for (size_t j = 0; j < component_extension_imes_[i].engines.size(); ++j) {
+      const std::string input_method_id =
+          extension_ime_util::GetComponentInputMethodID(
+              component_extension_imes_[i].id,
+              component_extension_imes_[i].engines[j].engine_id);
       result.push_back(
           input_method::InputMethodDescriptor(
-              extension_ime_util::GetComponentInputMethodID(
-                  component_extension_imes_[i].id,
-                  component_extension_imes_[i].engines[j].engine_id),
+              input_method_id,
               component_extension_imes_[i].engines[j].display_name,
               std::string(), // TODO(uekawa): Set short name.
               component_extension_imes_[i].engines[j].layouts,
               component_extension_imes_[i].engines[j].language_codes,
-              false,  // Do not use IME on login screen.
+              // Enables extension based xkb keyboards on login screen.
+              extension_ime_util::IsKeyboardLayoutExtension(input_method_id),

[Seigo Nonaka, 2014/02/25 06:57:19]

Please making sure you can change layout on login/lock screen.

[Shu Chen, 2014/02/25 08:52:51]

Verified it works at login/lock screen.

               component_extension_imes_[i].options_page_url,
               component_extension_imes_[i].input_view_url));
     }
   }
   return result;
 }
 
 void ComponentExtensionIMEManager::AddObserver(Observer* observer) {
   observers_.AddObserver(observer);
 }
@@ skipping 24 matching lines @@
         *out_extension = component_extension_imes_[i];
       if (out_engine)
         *out_engine = component_extension_imes_[i].engines[j];
       return true;
     }
   }
   return false;
 }
 
 }  // namespace chromeos