Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.cc

Issue 177093002: [IME] Loads chromeos-xkb extension and add the extension based xkb keyboards in the chrome://settin… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chromeos/ime/component_extension_ime_manager.cc » ('j') | chromeos/ime/component_extension_ime_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_util.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_util.cc b/chrome/browser/chromeos/input_method/input_method_util.cc
index 2c0f7512ef34c73107656a14a7c85b919dad25e8..e11dd25e34e545c664398cb4c900c5e7b21f1c90 100644
--- a/chrome/browser/chromeos/input_method/input_method_util.cc
+++ b/chrome/browser/chromeos/input_method/input_method_util.cc
@@ -341,8 +341,8 @@ bool InputMethodUtil::IsValidInputMethodId(
// static
bool InputMethodUtil::IsKeyboardLayout(const std::string& input_method_id) {
- const bool kCaseInsensitive = false;
- return StartsWithASCII(input_method_id, "xkb:", kCaseInsensitive);
+ return StartsWithASCII(input_method_id, "xkb:", false) ||
+ extension_ime_util::IsKeyboardLayoutExtension(input_method_id);
}
std::string InputMethodUtil::GetLanguageCodeFromInputMethodId(
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chromeos/ime/component_extension_ime_manager.cc » ('j') | chromeos/ime/component_extension_ime_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698