Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1770523002: Track connected subframes per-Document instead of per-Node. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track connected subframes per-Document instead of per-Node. This frees up 10 bits of space in NodeRareData for other uses. BUG=none

Patch Set 1 #

Patch Set 2 : Fix various crashes but still doesn't refcount tracked nodes (and needs to) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -222 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ChildFrameDisconnector.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 7 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.h View 4 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/core/dom/SubframeTracker.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/SubframeTracker.cpp View 1 1 chunk +92 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
dcheng
Here's my entry for overly clever CL of the week. It gets rid of the ...
4 years, 9 months ago (2016-03-04 23:26:20 UTC) #2
esprehn
4 years, 9 months ago (2016-03-07 22:01:16 UTC) #3
Yeah we could do this to save the bits if we really need them, it's not clear to
me we do need them today though. I'm not sure this is much less complexity
either.

Powered by Google App Engine
This is Rietveld 408576698