Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: third_party/WebKit/Source/core/dom/NodeRareData.h

Issue 1770523002: Track connected subframes per-Document instead of per-Node. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various crashes but still doesn't refcount tracked nodes (and needs to) Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | third_party/WebKit/Source/core/dom/NodeRareData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/NodeRareData.h
diff --git a/third_party/WebKit/Source/core/dom/NodeRareData.h b/third_party/WebKit/Source/core/dom/NodeRareData.h
index 4621a0c231360d0df485c54d70078bee5badff2a..673ff33571a8244307d9daff609f9b4a406e34a2 100644
--- a/third_party/WebKit/Source/core/dom/NodeRareData.h
+++ b/third_party/WebKit/Source/core/dom/NodeRareData.h
@@ -81,15 +81,6 @@ public:
return *m_mutationObserverData;
}
- unsigned connectedSubframeCount() const { return m_connectedFrameCount; }
- void incrementConnectedSubframeCount(unsigned amount);
- void decrementConnectedSubframeCount(unsigned amount)
- {
- ASSERT(m_connectedFrameCount);
- ASSERT(amount <= m_connectedFrameCount);
- m_connectedFrameCount -= amount;
- }
-
bool hasElementFlag(ElementFlags mask) const { return m_elementFlags & mask; }
void setElementFlag(ElementFlags mask, bool value) { m_elementFlags = (m_elementFlags & ~mask) | (-(int32_t)value & mask); }
void clearElementFlag(ElementFlags mask) { m_elementFlags &= ~mask; }
@@ -99,10 +90,6 @@ public:
bool hasRestyleFlags() const { return m_restyleFlags; }
void clearRestyleFlags() { m_restyleFlags = 0; }
- enum {
- ConnectedFrameCountBits = 10, // Must fit Page::maxNumberOfFrames.
- };
-
DECLARE_TRACE();
DECLARE_TRACE_AFTER_DISPATCH();
@@ -111,7 +98,6 @@ public:
protected:
explicit NodeRareData(LayoutObject* layoutObject)
: NodeRareDataBase(layoutObject)
- , m_connectedFrameCount(0)
, m_elementFlags(0)
, m_restyleFlags(0)
, m_isElementRareData(false)
@@ -121,7 +107,6 @@ private:
OwnPtrWillBeMember<NodeListsNodeData> m_nodeLists;
OwnPtrWillBeMember<NodeMutationObserverData> m_mutationObserverData;
- unsigned m_connectedFrameCount : ConnectedFrameCountBits;
unsigned m_elementFlags : NumberOfElementFlags;
unsigned m_restyleFlags : NumberOfDynamicRestyleFlags;
protected:
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.cpp ('k') | third_party/WebKit/Source/core/dom/NodeRareData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698