Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/dom/NodeRareData.cpp

Issue 1770523002: Track connected subframes per-Document instead of per-Node. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various crashes but still doesn't refcount tracked nodes (and needs to) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 66
67 void NodeRareData::finalizeGarbageCollectedObject() 67 void NodeRareData::finalizeGarbageCollectedObject()
68 { 68 {
69 RELEASE_ASSERT(!layoutObject()); 69 RELEASE_ASSERT(!layoutObject());
70 if (m_isElementRareData) 70 if (m_isElementRareData)
71 static_cast<ElementRareData*>(this)->~ElementRareData(); 71 static_cast<ElementRareData*>(this)->~ElementRareData();
72 else 72 else
73 this->~NodeRareData(); 73 this->~NodeRareData();
74 } 74 }
75 75
76 void NodeRareData::incrementConnectedSubframeCount(unsigned amount)
77 {
78 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION((m_connectedFrameCount + amount) <= FrameHost::maxNumberOfFrames);
79 m_connectedFrameCount += amount;
80 }
81
82 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow
83 static_assert(FrameHost::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameC ountBits), "Frame limit should fit in rare data count");
84
85 } // namespace blink 76 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/NodeRareData.h ('k') | third_party/WebKit/Source/core/dom/SubframeTracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698